Jump to content

Module talk:Check for unknown parameters

Page contents not supported in other languages.
Add topic
From Wikipedia, the free encyclopedia
Latest comment: 7 days ago by Johnuniq in topic Protected edit request on 2 October 2026

Edit request 26 June 2026

[edit]

Description of suggested change: Please sync the sandbox changes to add support for |pushpin_map_args=y which will allow for the auto inclusion of the new module for pushpin maps in Infoboxes. This follows the same syntax and layout that User:MSGJ added for me back in October of 2025. All in the name of consistency. If/when done, I will update the documentation. Need to have this in place before the rollout of the new module stats. --Zackmann (Talk to me/What I been doing) 22:17, 26 June 2026 (UTC)Reply

 Done — Martin (MSGJ · talk) 21:42, 28 June 2026 (UTC)Reply
@MSGJ: like an idiot I missed one... can you add 'pushpin_map', at line 16? Please and thank you! Zackmann (Talk to me/What I been doing) 22:06, 28 June 2026 (UTC)Reply

Protected edit request on 2 October 2026

[edit]

SUPER simple one. Please delete line 25 ('coord',) as shown in the sandbox. That parameter is no longer supported.

Zackmann (Talk to me/What I been doing) 23:00, 2 October 2026 (UTC)Reply

@MSGJ and Joy: could one of you possibly handle this? I know there is no deadline and all that, but it is causing a weird issue with a new bot that is being developed and therefore would LOVE to get this resolved. Thanks! Zackmann (Talk to me/What I been doing) 17:07, 4 October 2026 (UTC)Reply
@Primefac: maybe you can assist here? Please? Zackmann (Talk to me/What I been doing) 02:50, 7 October 2026 (UTC)Reply

Editing a module with this many transclusions is scary but I'll handle it after some thought. How can I confirm that coord is no longer supported? That boils down to knowing what modules/templates might set the mapframe_args parameter passed to this module. The presence of that parameter causes the mapframe_params table to be used. Johnuniq (talk) 04:57, 10 October 2026 (UTC)Reply

@Johnuniq: thanks for looking into this! Your concerns are totally valid. Couple of points:
  1. Special:Diff/1360972605/1378091936 shows the removal (by me) of |coord= from being supported by Module:Infobox mapframe
  2. The change I am requesting here will ONLY prevent |coord= from being auto-loaded into over 100 Infoboxes as an accepted parameter.
  3. The individual template can still set coord as an allowed parameter in the usual way, it will simply not be automatically included when |mapframe_args=y
  4. I have done extensive regex searching for uses of | coord = ... and am fairly confident that none remain in use in Infoboxes that rely on |mapframe_args=y
  5. In the event that there is a template using coord that somehow escaped my cleanup efforts, the only consequences of this edit request will be a preview warning on translcusions of that template in question when coord is set to not null and those same pages appearing the corresponding unknown param category, which I monitor on my userpage and will notice within a few hours of the category populating. While this would not be ideal and will absolutely be fixed by me if it occurs, I want to note that this issue would NOT prevent that parameter and its supplied value from still functioning as designed in the Infobox/on the page in quesiton..
For all those reasons I see this as a very low risk change, but am certainly open to any other concerns you may have! Thanks again. Zackmann (Talk to me/What I been doing) 05:09, 10 October 2026 (UTC)Reply
Done. Johnuniq (talk) 08:31, 10 October 2026 (UTC)Reply